Fix tests #2726
Merged
Fix tests #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
freekmurze
added a commit
that referenced
this pull request
Jan 14, 2022
* wip * wip * Fix styling * wip * Fix styling * wip * Fix styling * wip * wip * wip * PHPUnit to Pest Converter (#2724) * Add Pest dependencies * Add base Pest file * Convert test cases * Remove non-compound imports * Adopt expectation API * Optimize uses * Set return type of base TestCase methods From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html * Use Pest test runner * Shift cleanup * Fix styling * wip * wip * wip * wip * wip * Fix styling Co-authored-by: Shift <[email protected]> Co-authored-by: freekmurze <[email protected]> * wip * Fix styling * wip * wip * wip * Fix styling * wip * wip * wip * wip * wip * Fix styling * test fix (#2726) * wip * wip * wip * wip * Fix styling * wip * wip * wip * wip * Fix styling * wip * wip Co-authored-by: freekmurze <[email protected]> Co-authored-by: Shift <[email protected]> Co-authored-by: Fabio Ivona <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the "beforeEach already exist" error in pest test suite
Can't test the code, though (have not an S3 for testing)
my only fear is that you couldn't call Pest's
getS3BaseTestDirectory()directly fromS3TestPathGenerator.php, but the main issue is thatS3IntegrationTestclass was autoloaded by composer inS3TestPathGenerator.phpand it looked intoS3IntegrationTest.phptriggering beforeEach() a second time